use setState instead of direct assignment #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@Chevtek, do you have any ETA when you are able to merge the fix? |
|
thanks for the PR, unfortunately looks like component is dead :/ |
|
@karpikpl, @mynameistechno, @chevex |
|
Please do. |
|
Thanks you guys. Been going through some rough stuff for the last year and haven't had time to follow up with anything. I just merged this in and I'll publish it soon. Thanks for going the extra mile to get a fix out for everyone :) |
|
🤣 I have just published the fixed version 😆 |
|
Right, hence why I'm thanking you for getting a fix out despite my absence 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1
We are using this component in https://github.com/Kentico/cloud-sample-app-react and it does not look good to have warnings in the sample application.
I have just change what does the react see as a best practice - the state is updating asynchronously using
setStatemethod.