support for installation and interaction contexts #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chew
changed the title
Andre601
reviewed
May 17, 2024
| } else if (this.guildOnly) { | ||
| // remove bot dm from contexts | ||
| contexts.remove(InteractionContextType.BOT_DM); | ||
| } else if (!this.guildOnly) { |
There was a problem hiding this comment.
Pretty sure a simple } else { should work here given you already check for null and if it is true. And since it's a boolean can there only be false be left by the logic.
| } else if (this.guildOnly) { | ||
| // remove bot dm from contexts | ||
| contexts.remove(InteractionContextType.BOT_DM); | ||
| } else if (!this.guildOnly) { |
| } else if (this.guildOnly) { | ||
| // remove bot dm from contexts | ||
| contexts.remove(InteractionContextType.BOT_DM); | ||
| } else if (!this.guildOnly) { |
| } else if (this.guildOnly) { | ||
| // remove bot dm from contexts | ||
| contexts.remove(InteractionContextType.BOT_DM); | ||
| } else if (!this.guildOnly) { |
|
Until this is deployed to JDA, this will be on a snapshot release: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the most awful way of migrating guildOnly to the new installation contexts, but, it works. Accepting feedback on how this could be better!
Waiting for discord-jda/JDA#2633 to be merged before this is open for review.