Add "always respect user permissions" field #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andre601
reviewed
Aug 26, 2024
| * <br> | ||
| * This has no effect for text based commands or DMs. | ||
| */ | ||
| protected boolean alwaysRespectUserPermissions = false; |
There was a problem hiding this comment.
That's quite a mouth full... Maybe a shorter name could be better? Like forceUserPermissions, given that, from what I understand, this would force the bot to always check its user perms over server overrides?
| continue; | ||
|
|
||
| if(p.isChannel()) | ||
| if (alwaysRespectUserPermissions) |
There was a problem hiding this comment.
Given the size of the if-section here, this should probably be wrapped in {} for readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Pull Request Checklist
Please follow the following steps before opening this PR.
PRs that do not complete the checklist will be subject to denial for
missing information.
or merged features/bug fixes.
Pull Request Information
Check and fill in the blanks for all that apply:
commandsmodule of the JDA-Utilities library.______.Description
This adds a field for interactions that allows the userPermissions checks to be skipped. They aren't necessary on servers because you can override them in the integration settings, and if left unset, the userPermissions set will take precedent anyway. The most breaking change is it's false by default, but no one will notice.