Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoint for vault singleton creation #17093

Merged
merged 10 commits into from
Jan 8, 2024
Merged

Endpoint for vault singleton creation #17093

merged 10 commits into from
Jan 8, 2024

Conversation

geoffwalmsley
Copy link
Contributor

No description provided.

@geoffwalmsley geoffwalmsley requested a review from a team as a code owner December 19, 2023 17:41
@geoffwalmsley geoffwalmsley added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Jan 2, 2024
@geoffwalmsley geoffwalmsley changed the base branch from gw.vault_puzzles to long_lived/vault January 2, 2024 21:30
Quexington
Quexington previously approved these changes Jan 2, 2024
View reviewed changes
@Quexington Quexington dismissed their stale review January 3, 2024 15:08

The merge-base changed after approval.

Quexington
Quexington requested changes Jan 3, 2024
View reviewed changes
chia/rpc/wallet_rpc_api.py Outdated Show resolved Hide resolved
chia/rpc/wallet_rpc_api.py Outdated Show resolved Hide resolved
chia/rpc/wallet_rpc_api.py Outdated Show resolved Hide resolved
chia/rpc/wallet_rpc_api.py Outdated Show resolved Hide resolved
chia/rpc/wallet_rpc_api.py Outdated Show resolved Hide resolved
chia/rpc/wallet_rpc_api.py Outdated Show resolved Hide resolved
tests/wallet/vault/test_vault_wallet.py Show resolved Hide resolved
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jan 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7427290770

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 90.546%
Totals Coverage Status
Change from base Build 7425084443: -0.06%
Covered Lines: 94249
Relevant Lines: 104041
💛 - Coveralls

wjblanke
wjblanke approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@Quexington Quexington merged commit 7fc1d2a into long_lived/vault Jan 8, 2024
267 checks passed
@Quexington Quexington deleted the gw.vault_create_rpc branch January 8, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quexington Quexington Quexington approved these changes

@wjblanke wjblanke wjblanke approved these changes

Assignees
No one assigned
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog vault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geoffwalmsley @wjblanke @Quexington