Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkpoint: into main from release/2.4.0 @ 2fe28180762ac7f3cb49d54d6b40e3245862b4e1 #18182

Merged
merged 2 commits into from
Jun 14, 2024
Merged

checkpoint: into main from release/2.4.0 @ 2fe28180762ac7f3cb49d54d6b40e3245862b4e1 #18182

merged 2 commits into from
Jun 14, 2024

Conversation

AmineKhaldi
Copy link
Contributor

Source hash: 2fe2818
Remaining commits: 1

emlowe and others added 2 commits June 12, 2024 09:46
@emlowe
Use TYPE_CHECKING to work around python 3.8 limitations with generics (…
2fe2818 
…#18152)

* Use TYPE_CHECKING to work around python 3.8 limitations with generics

* Add comment about 3.8 specific workaround
@AmineKhaldi
Merge commit '2fe28180762ac7f3cb49d54d6b40e3245862b4e1' into checkpoi…
e12f1e5 
…nt/main_from_release_2.4.0_2fe28180762ac7f3cb49d54d6b40e3245862b4e1
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner June 14, 2024 17:12
@AmineKhaldi AmineKhaldi added checkpoint_merge Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels Jun 14, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9519845793

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 17 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.001%) to 90.863%
Files with Coverage Reduction New Missed Lines %
chia/server/node_discovery.py 1 79.61%
chia/full_node/full_node_api.py 2 81.66%
chia/farmer/farmer_api.py 2 94.4%
chia/server/ws_connection.py 2 88.69%
chia/full_node/full_node.py 10 85.91%
Totals Coverage Status
Change from base Build 9490807938: -0.001%
Covered Lines: 100017
Relevant Lines: 110015
💛 - Coveralls

@cmmarslender cmmarslender merged commit 7353bf5 into main Jun 14, 2024
366 checks passed
@cmmarslender cmmarslender deleted the checkpoint/main_from_release_2.4.0_2fe28180762ac7f3cb49d54d6b40e3245862b4e1 branch June 14, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

@altendky altendky altendky approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog checkpoint_merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AmineKhaldi @altendky @emlowe @cmmarslender