Revert "Revert "Revert "Revert "CHIA-414 fixup datalayer benchmark""" (#18223)"

[altendky]

This reverts commit eefca33.

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
pypi/big-o@0.11.0	eval, filesystem	0	52.6 kB	Pietro.Berkes
pypi/numpy@1.24.4	environment, eval, filesystem, network, shell, unsafe	0	98 MB	charlesr.harris, matthew.brett, mattip, ...2 more
pypi/numpy@2.0.1	environment, eval, filesystem, network, shell, unsafe	0	102 MB	charlesr.harris, matthew.brett, mattip, ...2 more
pypi/numpy@2.1.1	environment, eval, filesystem, network, shell, unsafe	0	101 MB	charlesr.harris, matthew.brett, mattip, ...2 more

View full report↗︎

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
AI-detected potential code anomaly	pypi/numpy@1.24.4	Notes: The code has several areas that raise security concerns, especially with the use of eval(), subprocesses, and directory manipulations. The potential for command injection and unsafe evaluations should not be overlooked. Caution is warranted if this code is to be used in a production environment, as it may allow for various malicious behaviors if exploited. Confidence: 0.38 Severity: 0.65	poetry.lock	🚫
Obfuscated code	pypi/numpy@1.24.4	Confidence: 0.75 Location: Package overview	poetry.lock	⚠︎
AI-detected potential code anomaly	pypi/big-o@0.11.0	Notes: The code contains multiple potential security risks, including unauthorized file writes, command injection, information leakage, and code injection. It should be reviewed and modified to ensure proper input validation, sanitization, and secure handling of user input. The presence of 'eval' raises concerns about the safety and security of the code. Confidence: 0.80 Severity: 0.70	poetry.lock pyproject.toml	🚫
AI-detected potential code anomaly	pypi/numpy@2.0.1	Notes: The code contains multiple potential security risks, including unauthorized file writes, command injection, information leakage, and code injection. It should be reviewed and modified to ensure proper input validation, sanitization, and secure handling of user input. The presence of 'eval' raises concerns about the safety and security of the code. Confidence: 0.80 Severity: 0.70	poetry.lock	🚫
AI-detected potential security risk	pypi/numpy@2.0.1	Notes: The script contains multiple potential security risks including downloading and executing code from untrusted sources, manipulating environment variables based on external output, and installing a large number of packages. These behaviors could be exploited for malicious intent, making it a security risk. Confidence: 0.80 Severity: 0.70	poetry.lock	🚫
AI-detected potential security risk	pypi/numpy@2.0.1	Notes: The script generally performs typical environment setup tasks but includes a highly risky operation of executing a script fetched directly from the internet. This action increases the vulnerability to malicious code injection if the external source is compromised. Confidence: 0.80 Severity: 0.75	poetry.lock	🚫
AI-detected potential security risk	pypi/numpy@2.0.1	Notes: The code exhibits potential security risks due to the use of user-provided inputs in command execution and background execution of downloaded executables. The use of 'start' command to run the downloaded executable in the background could also be a red flag for suspicious behavior. Confidence: 0.80 Severity: 0.72	poetry.lock	🚫
AI-detected potential security risk	pypi/numpy@2.0.1	Notes: The use of pickle for deserializing objects presents a significant risk of arbitrary code execution, especially if untrusted data is being unpickled. The execution of external commands based on input requires careful validation to avoid command injection vulnerabilities. The manipulation of environment variables and file I/O operations also present potential security risks if not properly handled. Confidence: 0.80 Severity: 0.75	poetry.lock	🚫
AI-detected potential code anomaly	pypi/numpy@2.1.1	Notes: The code contains multiple potential security risks, including unauthorized file writes, command injection, information leakage, and code injection. It should be reviewed and modified to ensure proper input validation, sanitization, and secure handling of user input. The presence of 'eval' raises concerns about the safety and security of the code. Confidence: 0.80 Severity: 0.70	pyproject.toml	🚫
AI-detected potential security risk	pypi/numpy@2.1.1	Notes: The script contains multiple potential security risks including downloading and executing code from untrusted sources, manipulating environment variables based on external output, and installing a large number of packages. These behaviors could be exploited for malicious intent, making it a security risk. Confidence: 0.80 Severity: 0.70	pyproject.toml	🚫
AI-detected potential security risk	pypi/numpy@2.1.1	Notes: The script generally performs typical environment setup tasks but includes a highly risky operation of executing a script fetched directly from the internet. This action increases the vulnerability to malicious code injection if the external source is compromised. Confidence: 0.80 Severity: 0.75	pyproject.toml	🚫
AI-detected potential security risk	pypi/numpy@2.1.1	Notes: The code exhibits potential security risks due to the use of user-provided inputs in command execution and background execution of downloaded executables. The use of 'start' command to run the downloaded executable in the background could also be a red flag for suspicious behavior. Confidence: 0.80 Severity: 0.72	pyproject.toml	🚫
AI-detected potential security risk	pypi/numpy@2.1.1	Notes: The use of pickle for deserializing objects presents a significant risk of arbitrary code execution, especially if untrusted data is being unpickled. The execution of external commands based on input requires careful validation to avoid command injection vulnerabilities. The manipulation of environment variables and file I/O operations also present potential security risks if not properly handled. Confidence: 0.80 Severity: 0.75	pyproject.toml	🚫

View full report↗︎

Next steps

What is an AI-detected potential code anomaly?

AI has identified unusual behaviors that may pose a security risk.

An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

What is obfuscated code?

Obfuscated files are intentionally packed to hide their behavior. This could be a sign of malware.

Packages should not obfuscate their code. Consider not using packages with obfuscated code

What are AI-detected potential security risks?

AI has determined that this package may contain potential security issues or vulnerabilities.

An AI system identified potential security problems in this package. It is advised to review the package thoroughly and assess the potential risks before installation. You may also consider reporting the issue to the package maintainer or seeking alternative solutions with a stronger security posture.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore pypi/numpy@1.24.4
• @SocketSecurity ignore pypi/big-o@0.11.0
• @SocketSecurity ignore pypi/numpy@2.0.1
• @SocketSecurity ignore pypi/numpy@2.1.1

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

File	Coverage	Missing Lines
chia/_tests/core/data_layer/test_data_store.py	31.1%	lines 1531, 1548, 1550-1555, 1557-1560, 1562, 1565-1566, 1568-1577, 1580-1584, 1586
chia/_tests/process_junit.py	0.0%	lines 192-198, 200, 202, 204-205, 207-208, 211-212, 215, 244, 247, 252, 254, 321, 324, 329, 331
chia/_tests/util/misc.py	20.0%	lines 399, 401-403, 406-407, 413, 421

Total	Missing	Coverage
79 lines	63 lines	20%

[coveralls-official]

Pull Request Test Coverage Report for Build 10965212298

Details

• 16 of 79 (20.25%) changed or added relevant lines in 3 files are covered.
• 18 unchanged lines in 6 files lost coverage.
• Overall coverage decreased (-0.03%) to 90.943%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
chia/_tests/util/misc.py	2	10	20.0%
chia/_tests/process_junit.py	0	24	0.0%
chia/_tests/core/data_layer/test_data_store.py	14	45	31.11%

Files with Coverage Reduction	New Missed Lines	%
chia/full_node/full_node_api.py	1	82.36%
chia/_tests/process_junit.py	1	0.0%
chia/wallet/util/wallet_sync_utils.py	1	86.54%
chia/server/node_discovery.py	4	80.67%
chia/full_node/full_node.py	4	86.65%
chia/wallet/wallet_node.py	7	88.15%

Totals
Change from base Build 10949495080:	-0.03%
Covered Lines:	102033
Relevant Lines:	112163

---

💛 - Coveralls

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.