[CHIA-1156] Tweak gather_signing_info to work with multiple vaults and finish TXs
#18476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
Changed
Quexington
changed the title
gather_signing_info to work with multiple vaults and finish TXsgather_signing_info to work with multiple vaults and finish TXs
geoffwalmsley
approved these changes
Aug 19, 2024
|
markelrod
reviewed
Aug 20, 2024
markelrod
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some other work, I noticed that the Vault's
gather_signing_infomethod was a little bit rigid in what it would sign. It would only sign one single vault spend in a bundle that it saw, and it would also assume that every vault spend that it saw needed to be signed. This PR makes sure it only attempts to sign vaults that have a p2_delegated_secp puzzle inside and also allows it to sign multiple at once.