multiprocess_validation refactor

[arvidn]

Purpose:

This patch removes the thin wrapper pre_validate_blocks_multiprocess() method from the Blockchain class.
Specifically, this part of the patch: https://github.com/Chia-Network/chia-blockchain/pull/18541/files#diff-40409ea13958d9e8cec2be388c12e68da7c3179de55f01879713c5abdb1fed38L799-L825

The purpose of this wrapper is to pass the constants, self (as the BlocksProtocol) and ProcessPoolExecutor (also a member of Blockchain) into the underlying call to the free functionpre_validate_blocks_multiprocessing().

The reason to remove it is to prepare call sites for passing in other classes implementing the BlocksProtocol, such as AugmentedBlockchain, to support pipelining block validation during long sync.

The underlying free function takes more parameters, specifically, ConsensusConstants, BlocksProtocol and ProcessPoolExecutor. To reduce the impact of these additional parameters, two other parameters are removed; check_filter and batch_size. In all calls these are always set to True and 4, respectively. In fact, the batch_size can probably be removed (along with the batching itself) once validation is run in threads.

Current Behavior:

Many calls to pre_validate_blocks_multiprocessing() are made via the wrapper in Blockchain, passing in the blockchain object itself.

pre_validate_blocks_multiprocessing() takes parameters check_filter and batch_size.

New Behavior:

All calls to pre_validate_blocks_multiprocessing() explicitly pass in the object implementing the BlocksProtocol (e.g. Blockchain).

pre_validate_blocks_multiprocessing() no longer takes parameters check_filter and batch_size, but hard code those to True and 4.

[coveralls-official]

Pull Request Test Coverage Report for Build 10748783848

Details

• 231 of 250 (92.4%) changed or added relevant lines in 12 files are covered.
• 25 unchanged lines in 10 files lost coverage.
• Overall coverage increased (+0.01%) to 90.919%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
chia/consensus/multiprocess_validation.py	26	28	92.86%
chia/_tests/blockchain/test_augmented_chain.py	77	82	93.9%
chia/util/augmented_chain.py	76	88	86.36%

Files with Coverage Reduction	New Missed Lines	%
chia/timelord/timelord.py	1	81.78%
chia/rpc/rpc_server.py	1	88.82%
chia/consensus/get_block_generator.py	1	95.0%
chia/wallet/util/wallet_sync_utils.py	1	86.54%
chia/full_node/full_node.py	1	86.86%
chia/server/ws_connection.py	3	87.96%
chia/wallet/wallet_node.py	4	88.37%
chia/_tests/blockchain/test_get_block_generator.py	4	92.0%
chia/full_node/weight_proof.py	4	90.51%
chia/_tests/core/util/test_lockfile.py	5	89.47%

Totals
Change from base Build 10745304670:	0.01%
Covered Lines:	101681
Relevant Lines:	111810

---

💛 - Coveralls

[AmineKhaldi]

Looks good. Added some suggestions to keep the calls consistent and Blockchain oriented.