Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-1362 Deduct block overhead from the mempool's maximum block clvm cost limit #18574

Merged

Conversation

AmineKhaldi
Copy link
Contributor

@AmineKhaldi AmineKhaldi commented Sep 10, 2024

Purpose:

Account for the block overhead when creating a mempool bundle for the purpose of block creation, to ensure we never exceed the block maximum clvm cost limit.

Current Behavior:

We use maximum block clvm cost as the limit when creating the mempool bundle without regard for block overhead.

New Behavior:

We deduct the block overhead from the maximum block clvm cost limit itself.

@AmineKhaldi AmineKhaldi added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Sep 10, 2024
@AmineKhaldi AmineKhaldi self-assigned this Sep 10, 2024
Copy link

coveralls-official bot commented Sep 10, 2024

Pull Request Test Coverage Report for Build 10944333553

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 14 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.004%) to 90.991%

Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 73.03%
chia/full_node/pending_tx_cache.py 1 96.63%
chia/full_node/full_node_api.py 1 82.36%
chia/rpc/rpc_server.py 1 87.83%
chia/farmer/farmer.py 1 73.83%
chia/wallet/util/wallet_sync_utils.py 1 86.54%
chia/timelord/timelord_launcher.py 1 70.55%
chia/daemon/client.py 1 73.33%
chia/wallet/wallet_node.py 3 88.44%
chia/full_node/full_node.py 3 86.65%
Totals Coverage Status
Change from base Build 10928327080: 0.004%
Covered Lines: 102034
Relevant Lines: 112112

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review September 10, 2024 15:46
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner September 10, 2024 15:46
chia/full_node/mempool.py Outdated Show resolved Hide resolved
chia/full_node/mempool.py Outdated Show resolved Hide resolved
chia/_tests/core/mempool/test_mempool_manager.py Outdated Show resolved Hide resolved
@AmineKhaldi AmineKhaldi force-pushed the deduct_block_overhead_mempool_bundle branch from a143d8d to e8c79e1 Compare September 19, 2024 10:18
@AmineKhaldi AmineKhaldi force-pushed the deduct_block_overhead_mempool_bundle branch from e8c79e1 to b339ef3 Compare September 19, 2024 15:40
@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Sep 21, 2024
@pmaslana pmaslana merged commit 19dd1e0 into Chia-Network:main Sep 23, 2024
370 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants