Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-1388 Check the cat list values from get_cat_list against the default cats in test_cat_endpoints #18587

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

This covers not only the length of the returned list, but the contents as well.

Current Behavior:

We check if get_cat_list returns a list with the expected length against default CATs.

New Behavior:

We check both the length and the contents returned by get_cat_list against default CATs.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Sep 13, 2024
@AmineKhaldi AmineKhaldi self-assigned this Sep 13, 2024
@AmineKhaldi AmineKhaldi force-pushed the test_get_cat_list_values_test_cat_endpoints branch from 2f0f4f3 to f02a84c Compare September 13, 2024 17:12
Copy link

Pull Request Test Coverage Report for Build 10853281709

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 24 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.03%) to 90.997%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.59%
chia/daemon/keychain_proxy.py 1 73.03%
chia/farmer/farmer.py 1 72.27%
chia/wallet/util/wallet_sync_utils.py 1 86.54%
chia/server/node_discovery.py 1 81.03%
chia/daemon/client.py 1 73.33%
chia/full_node/full_node.py 2 86.84%
chia/wallet/wallet_node.py 4 88.72%
chia/full_node/weight_proof.py 4 90.51%
chia/timelord/timelord.py 8 80.71%
Totals Coverage Status
Change from base Build 10852332555: 0.03%
Covered Lines: 102041
Relevant Lines: 112106

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review September 18, 2024 11:15
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner September 18, 2024 11:15
@pmaslana pmaslana merged commit c6630f9 into Chia-Network:main Sep 24, 2024
368 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants