Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHIA-1307] Port key management RPCs to @marshal decorator #18593

Merged
merged 11 commits into from
Sep 24, 2024
Merged

[CHIA-1307] Port key management RPCs to @marshal decorator #18593

merged 11 commits into from
Sep 24, 2024

Conversation

Quexington
Copy link
Contributor

This begins a thread of PRs to add the @marshal decorator to every RPC endpoint in the wallet RPC. This specific PR tackles only the key management ones for now.

@Quexington Quexington added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Sep 17, 2024
@Quexington Quexington marked this pull request as ready for review September 20, 2024 16:17
@Quexington Quexington requested a review from a team as a code owner September 20, 2024 16:17
altendky
altendky requested changes Sep 23, 2024
View reviewed changes
chia/rpc/wallet_request_types.py Show resolved Hide resolved
chia/_tests/wallet/rpc/test_wallet_rpc.py Show resolved Hide resolved
chia/rpc/wallet_request_types.py Show resolved Hide resolved
chia/rpc/wallet_rpc_api.py Show resolved Hide resolved
chia/rpc/wallet_request_types.py Show resolved Hide resolved
altendky
altendky previously approved these changes Sep 23, 2024
View reviewed changes
@Quexington
Copy link
Contributor Author

I manually tested the test uncovered line chia\cmds\cmds_util.py:173 and it worked fine

@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main labels Sep 24, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Sep 24, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Sep 24, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Sep 24, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Sep 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/cmds_util.py 57.1% lines 173, 233-234
chia/data_layer/data_layer.py 66.7% lines 248-249
chia/rpc/wallet_request_types.py 98.6% lines 78
chia/rpc/wallet_rpc_api.py 86.7% lines 409, 423, 458, 470, 493, 588
Total Missing Coverage
186 lines 12 lines 93%

@Quexington Quexington added ready_to_merge Submitter and reviewers think this is ready and removed coverage-diff labels Sep 24, 2024
@pmaslana pmaslana merged commit bffb7b1 into main Sep 24, 2024
375 of 376 checks passed
@pmaslana pmaslana deleted the quex.key_management_to_marshal branch September 24, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markelrod markelrod markelrod approved these changes

@altendky altendky altendky left review comments

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Quexington @altendky @markelrod @pmaslana