[CHIA-1087] Simplify batch pre validate blocks #18602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
the
Changed
arvidn
force-pushed
the
simplify-batch_pre_validate_blocks
branch
from
4e40404
to
456c4d5
Compare
AmineKhaldi
previously approved these changes
Sep 19, 2024
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
arvidn
force-pushed
the
simplify-batch_pre_validate_blocks
branch
from
456c4d5
to
63489b6
Compare
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
arvidn
changed the title
AmineKhaldi
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed one commit at a time.
Purpose:
We currently use
NPCResultsin many places where the error cannot be set. This PR is a small step towards using the (inner)SpendBundleConditionsdirectly in those cases.Specifically, it makes
batch_pre_validate_blocks()take a dict ofSpendBundleConditionsinstead ofNPCResults.It also introduces an early exit in case
get_name_puzzle_conditions()returns a failure.The
PreValidationResultsstill contains anNPCResult, as it's a bit more work to make it useSpendBundleConditionsdirectly. Although, it could; the error is not allowed to be set.Current Behavior:
batch_pre_validate_blocks()takes a dict ofuint32->NPCResult.New Behavior:
batch_pre_validate_blocks()takes a dict ofuint32->SpendBundleConditions.