Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-1453] catchup: long_lived/vault from main @ 111b0e57d5995d760cac877c45ef8822506800b6 #18623

Conversation

Quexington
Copy link
Contributor

Source hash: 111b0e5
Remaining commits: 0
Merge diffs: (no conflicts except poetry)

AmineKhaldi and others added 7 commits September 16, 2024 11:50
…ms (#18586)

Simplify fetching TX data in create_bundle_from_mempool_items.
Bumps [py3createtorrent](https://github.com/rsnitsch/py3createtorrent) from 1.1.0 to 1.2.1.
- [Release notes](https://github.com/rsnitsch/py3createtorrent/releases)
- [Commits](rsnitsch/py3createtorrent@v1.1.0...v1.2.1)

---
updated-dependencies:
- dependency-name: py3createtorrent
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pytest](https://github.com/pytest-dev/pytest) from 8.1.1 to 8.3.3.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@8.1.1...8.3.3)

---
updated-dependencies:
- dependency-name: pytest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Remove no longer needed tx_bytes in add_transaction.
* Add version number to every log line

* Switch to using the __version__ variable in the logs

* Make line of code shorter to satisfy code standards

* Fix multiline code formatting

* code formatting
* Port `test_trade_cancellation`

* Delete obsolete test

* Port `test_trade_conflict`

* Port `test_trade_bad_spend`

* Port `test_trade_high_fee`

* Port `test_aggregated_trade_state`

* Remove DEFAULT_TX_CONFIG

* Remove accidental comments

* Use fee in our respond_to_offer call.

* Minor readability tweak.

---------

Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org>
…long_lived_vault_from_main_111b0e57d5995d760cac877c45ef8822506800b6
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: pypi/py3createtorrent@1.1.0, pypi/pytest@8.1.1

View full report↗︎

@Quexington Quexington added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Sep 23, 2024
@Quexington Quexington marked this pull request as ready for review September 23, 2024 15:07
@Quexington Quexington requested a review from a team as a code owner September 23, 2024 15:07
@Quexington Quexington changed the title catchup: long_lived/vault from main @ 111b0e57d5995d760cac877c45ef8822506800b6 [CHIA-1453] catchup: long_lived/vault from main @ 111b0e57d5995d760cac877c45ef8822506800b6 Sep 23, 2024
Copy link

Pull Request Test Coverage Report for Build 10996985270

Details

  • 120 of 120 (100.0%) changed or added relevant lines in 4 files are covered.
  • 80 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.06%) to 91.063%

Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 82.36%
chia/rpc/rpc_server.py 1 88.82%
chia/wallet/util/wallet_sync_utils.py 1 86.54%
chia/timelord/timelord_launcher.py 2 71.92%
chia/data_layer/data_layer.py 2 85.8%
chia/server/server.py 4 82.21%
chia/full_node/full_node.py 5 86.36%
chia/server/address_manager.py 7 90.48%
chia/farmer/farmer.py 7 72.57%
chia/wallet/wallet_node.py 7 88.57%
Totals Coverage Status
Change from base Build 10907322348: -0.06%
Covered Lines: 103595
Relevant Lines: 113736

💛 - Coveralls

@markelrod
Copy link
Contributor

coverage exception ok

@Quexington Quexington merged commit f9a01d9 into long_lived/vault Sep 24, 2024
377 of 378 checks passed
@Quexington Quexington deleted the catchup/long_lived_vault_from_main_111b0e57d5995d760cac877c45ef8822506800b6 branch September 24, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants