Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump chia rs 0.14.0 #18643

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Bump chia rs 0.14.0 #18643

merged 5 commits into from
Sep 26, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Sep 26, 2024

This PR is best reviewed one commit at a time.

Purpose:

Changes since last chia_rs release can be found here: https://github.com/Chia-Network/chia_rs/releases/tag/0.14.0

The main feature of this update is to fix validate_clvm_and_signature() to release the GIL. This was an oversight in the previous version where this function was first ported to rust. We are already using this function in a python thread in chia-blockchain.

Additionally, a few feature flags have been removed now (and enabled unconditionally) as soft0fork 4 and 5 as well as the hard fork have activated. This is reflected in chia-blockchain by removing all references to them.

Current Behavior:

  • the behavior of div depends on the block height
  • BLS operators are only available outside the softfork guard after the hard fork block height
  • public keys are allowed to be the infinity G1 point (and just ignored)
  • BLSCache.update() takes a list of (bytes, bytes)

New Behavior:

  • the behavior of div is correct, unconditionally
  • BLS operators are available outside the softfork guard unconditionally
  • public keys are not allowed to be the infinity G1 point
  • BLSCache.update() takes a list of (bytes, GTElement)

Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: pypi/chia-rs@0.13.0

View full report↗︎

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Sep 26, 2024
@arvidn arvidn marked this pull request as ready for review September 26, 2024 10:11
@arvidn arvidn requested a review from a team as a code owner September 26, 2024 10:11
@arvidn arvidn requested a review from emlowe September 26, 2024 13:32
@pmaslana pmaslana merged commit 0764c8d into main Sep 26, 2024
372 of 373 checks passed
@pmaslana pmaslana deleted the bump-chia-rs-0.14.0 branch September 26, 2024 15:55
@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants