Fix up SD1 initialization for KL2x #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of KINETIS_SERIAL0_IS_UARTLP: * the argument to `sd_lld_init_driver` needs to be explicitly coerced to a pointer of type `UART_TypeDef`; * the initialization of `c4_p` needs to be patched, as its position is different in the underlying `UARTLP_TypeDef`.
fpoussin
requested changes
May 15, 2020
There was a problem hiding this comment.
It's actually broken:
/home/jenkinsremote/workspace/ChibiOS-Contrib_PR-219@2/os/hal/ports/KINETIS/LLD/UARTv1/hal_serial_lld.c: In function 'sd_lld_init':
/home/jenkinsremote/workspace/ChibiOS-Contrib_PR-219@2/os/hal/ports/KINETIS/LLD/UARTv1/hal_serial_lld.c:434:24: error: 'UARTLP_TypeDef' {aka 'struct <anonymous>'} has no member named 'c4_p'
434 | SD1.uart.c4_p = UART0->c4_p; /* fix up misconfigured C4 register */
| ^~
make: *** [build/obj/hal_serial_lld.o] Error 1
|
My apologies for submitting a broken patch. I added it directly by editing on github, working from memory. I have fixed it and tested it locally. |
fpoussin
approved these changes
May 17, 2020
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of KINETIS_SERIAL0_IS_UARTLP:
sd_lld_init_driverneeds to be explicitly coerced to a pointer of typeUART_TypeDef;c4_pneeds to be patched, as its position is different in the underlyingUARTLP_TypeDef.