Port demo to Teensy 3.6 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting the mcuconf and Makefile changes right is non-trivial for a beginner, so this will be helpful for others who want to get started with ChibiOS on a Teensy 3.6.
stapelberg
force-pushed
the
demo_teensy36
branch
2 times, most recently
from
449731b to
ab9e587
Compare
|
Okay, after including the HSRUN fix (largely just including PJRC’s code), the firmware works on my Teensy 3.6 and jenkins passes :) This is now ready to review. |
fpoussin
approved these changes
Jun 6, 2020
|
All good, thank you |
|
Awesome, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the mcuconf and Makefile changes right is non-trivial for a beginner, so
this will be helpful for others who want to get started with ChibiOS on a Teensy 3.6.
I have split out the mechanical copying of the old demo into one commit, and the required changes for working on the Teensy 3.6 into the other commit, so I recommend looking only at one at a time for a better picture of what is going on :)
cc @walkerstop — thanks for your work on the Teensy 3.6 support in ChibiOS! Maybe you could take a quick look at this PR, too. Perhaps you have an idea about tickless mode not working? See the TODO in chconf.h:
Edit: this is now ready to review.