[RP2040] Init USB out endpoints on transfer start #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting a receive operation on an out endpoint it has to be configured before the out interrupt occurs, or otherwise a sequence error is the result.
KarlK90
changed the title
35 tasks
|
Looks good for me. Thank you finding the problem in the driver. |
Great! 🙂 @fpoussin feel free to merge on your approval! |
fpoussin
approved these changes
Mar 10, 2022
|
LGTM, thanks! |
|
Great! Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hanya I found an error in the USB driver, when starting new out transfers the out endpoint has to be configured immediately or otherwise a data sequence error is generated. The actual fix is on line 873 in
usb_lld_start_out()Could you confirm / review my changes?The only notable other change was the condition for detecting an short package, which in my understanding is only the case if the transfer length is under 64 Byte? Also
rxpktsis an unsigned integer so can never be smaller than 0, therefore I changed the check to equals.With these changes QMK successfully enumerates with the HID descriptors.