[RP2040] usb: fix usb_lld_get_status functions #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the USB endpoint get status functions; previously the (wrong) assumptions were the following: * `active` was toggled depending on whether a transaction was currently ongoing on the endpoint e.g., if the endpoint is "busy." What is actually requested is if this endpoint is enabled at all. Therefore, we check the `enabled` flag in the endpoint control register. * `stalled` was toggled by the device itself, although this property is completely controlled by the host via the SET and CLEAR feature requests. Therefore, we check the `stalled` flag in the endpoint buffer control register.
KarlK90
force-pushed
the
fix/rp2040-usb-get-status-request
branch
from
c05ef9e
to
1a1bbe6
Compare
14 tasks
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the USB endpoint get status functions; previously the (wrong) assumptions were the following:
activewas toggled depending on whether a transaction was currently ongoing on the endpoint e.g., if the endpoint is "busy." What is actually requested is if this endpoint is enabled at all. Therefore, we check theenabledflag in the endpoint control register.stalledwas toggled by the device itself, although this property is completely controlled by the host via the SET and CLEAR feature requests. Therefore, we check thestalledflag in the endpoint buffer control register.