-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.42.0 #1946
Merged
Merged
Release/1.42.0 #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add "Unassign Activity" menu item Add "Unassign Activity" menu item with visibility and disabled state reflecting assignment permission and status. Adjust other menu items accordingly. When clicked, "Unassign Activity" currently only sets a state variable – the unassign drawer/popup itself is coming in a subsequent commit. Required introducing API activity/flow types that include `assignments` property to determine whether participant is assigned to each activity/ flow. Also opted to strongly type the `/activities/applet/{applet_id}` endpoint response. * refactor: share assign drawer subcomponent & hook Move the `AssignmentCounts` subcomponent of `ActivityAssignDrawer` to a shared location to be eventually consumed by `ActivityUnassignDrawer`. Also make its banners hook generic, move it to the shared hooks folder, and rename it to `useModalBanners`. * feat: add `ActivityUnassignDrawer` This component includes both the unassign panel (when there are multiple assignments), and the unassign confirmation popup (when there is only one assignment, or after submitting the form in the panel). Enhanced `useAsync` to be able to read the arguments passed for the current async call after it completes, to be able to populate the success banner when the required info is not returned by the response. * feat: incorporate `ActivityUnassignDrawer` ⇒ PDP In making this change, we still need to fetch the `/activities/applet/{applet_id}` endpoint to populate the Unassigned section, per the original PDP designs. This is obviously costly in performance, but this version of the PDP is only here temporarily to be able to properly test the unassign flow. * fix: remove useless Search field in PDP header * fix: reduce `:first-child` console warnings * test: add tests for `ActivityUnassignDrawer` Also make use of reusable mocks in some existing tests. * fix: address activity/flow language nuances Also create shared `FlowChip` component that is reused wherever a flow is shown in the Dashboard (was also missing from the Take Now modal).
This PR updates the dataviz summary page with the following new visualizations of subscale severity: - The style of the points on the line chart have been updated to match the severity designs - The severity of a point has been added to the tooltip for each point on the line chart - The severity has been added to the additional information block of the expandable subscale card when the data is displayed using a line chart - A legend has been added below the line chart explaining the severity point styles This feature is behind the flag `enableCahmiSubscaleScoring`
fix/M2-7833: allowing only one block on flanker (#1930) * fix/M2-7833_allowing_only_one_block_on_flanker * fix/ fixing Flanker on Add Performance Tasks, changing the items quantity * chore/removing_isLastTest_from_saveAndPublish * chore/removing parentheses from getScoreConditions in builderApplet.utils.tsx --------- Co-authored-by: Felipe Imperio <felipeimp@Felipes-MacBook-Pro.local>
…age-item-conditional feature: add Message ItemType support in SummaryRow (M2-7981)
…2-7981-message-item-conditional Revert "feature: add Message ItemType support in SummaryRow (M2-7981)"
…age-conditional feat: add Message ItemType support in SummaryRow (M2-7981)
ChaconC
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release / merging 1.42.0 to
main