Release/1.45.4 [main] #1997
Merged
Release/1.45.4 [main] #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the following events to Mixpanel tracking: - `Start Assign Activity/Flow` - `Confirm Assign Activity/Flow` - `Start Unassign Activity/Flow` - `Confirm Unassign Activity/Flow` It also updates the `Applet Save click` event to add some extra properties related to activity and flow assignments
Whenever a release candidate deployment happens from this repository, a GitHub Actions workflow attempts to process the tickets it contains, and consumes a Jira webhook that triggers an automation to move those tickets into the "To Be Tested" column. I recently updated that automation to also leave a comment on the ticket when the deployment happens This PR adds more details to the webhook call so that the comment may include more details about the deployment. These details are: - The release candidate tag - The repository URL
…#1989) * feat: add additional SSI properties to analytics The data team has requested tracking new SSI properties in Mixpanel, as well as requested that hidden items be ignored from all counts. * test: update/add unit tests
…et-reports-updates feature: Applet reports updates (M2-7254)
* feat: add API call & types for counts * feat: update `MaybeEmpty` to support loading state Also switched from changing color when value missing to changing opacity instead, which aligns empty placeholder styling better with the inherited colour (such as in the selected tab pill). * chore: shorten `StyledMaybeEmpty` import paths * feat: call counts endpoint after initial API call Note that `AssignmentTabProps` was not in fact in use (an outdated earlier iteration that was never cleaned up), but now we need it to pass count values to the shared `AssignmentsTab` component. * fix: exclude all activities load state to boost UX The only reason we load all activities is to ensure Take Now has correct enabled/disabled state. It's unnecessary to await the slower request to complete before making the page interactive, so adjusted logic to simply temporarily hide Take Now until that request has completed. This supports more responsive UX until 7906 is completed, obviating the need to load all activities at all in the future. Also slightly increased MaybeEmpty's loading state animation speed. * fix: align `folder-opened` icon to Figma latest * feat: add counters to `ActivityListItem`s Also clarify meanings of ambiguously-named properties returned by the API. * test: add counter/empty state tests, add a11y Enhance `MaybeEmpty` component to be more a11y-friendly, and also easier to test loading & empty states for. Also add tests for `ActivityListItemCounter`.
rcmerlo
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release/1.45.4