Migrating project to swift 4 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @fpinvidio , Do we need flag SWIFT_SWIFT3_OBJC_INFERENCE to be |
|
Actually it should be set to default or off. But before changing it, it would be wise to run the project with the env variable SWIFT_DEBUG_IMPLICIT_OBJC_ENTRYPOINT for identifying any remaining functions that need @objc. |
|
It makes a lot of sense to use this flag, as it reduces the file size of the project's binary. |
chili-ios
approved these changes
Oct 2, 2017
|
Are you going to merge this PR? Nice lib btw ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed updateFrame function to objc as required for swift-4.
Updated project settings.