Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: follow macOS's trust settings #696

Closed
Chilledheart opened this issue Jan 23, 2024 · 0 comments · Fixed by #697
Closed

Feature: follow macOS's trust settings #696

Chilledheart opened this issue Jan 23, 2024 · 0 comments · Fixed by #697
Labels
Client Command Line Client Issues P2 Medium Priority

Comments

@Chilledheart
Copy link
Owner

Currently the app follows system domain which all roots are trusted.

see https://chromium.googlesource.com/chromium/src/+/refs/tags/122.0.6261.1/net/cert/internal/trust_store_mac.cc#202
and golang/go@7e5b2e0#diff-f20b5c60b63ce74aba61b54a21edcb202d3ffdcbd71993585a5a1194e6f1933dR120

@Chilledheart Chilledheart added P2 Medium Priority Client Command Line Client Issues labels Jan 23, 2024
Chilledheart added a commit that referenced this issue Jan 23, 2024
Evaluate user trust domain, then admin. User settings can override
admin (and both override the system domain, but we don't check that).

Fixes #696.
Chilledheart added a commit that referenced this issue Jan 23, 2024
Evaluate user trust domain, then admin. User settings can override
admin (and both override the system domain, but we don't check that).

Fixes #696.
Chilledheart added a commit that referenced this issue Jan 23, 2024
Evaluate user trust domain, then admin. User settings can override
admin (and both override the system domain, but we don't check that).

Fixes #696.
Chilledheart added a commit that referenced this issue Jan 23, 2024
Evaluate user trust domain, then admin. User settings can override
admin (and both override the system domain, but we don't check that).

Fixes #696.
Chilledheart added a commit that referenced this issue Jan 23, 2024
Evaluate user trust domain, then admin. User settings can override
admin (and both override the system domain, but we don't check that).

Fixes #696.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client Command Line Client Issues P2 Medium Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant