Fixed string literals in places of enum values have to raise a query …

…errors. (#2846)
ChilliCream · Jan 13, 2021 · bb459e3 · bb459e3
1 parent 1dc6ca0
commit bb459e3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/HotChocolate/Core/src/Validation/Rules/ValueVisitor.cs b/src/HotChocolate/Core/src/Validation/Rules/ValueVisitor.cs
@@ -382,6 +382,12 @@ private bool IsInstanceOfType(
                 return true;
             }
 
+            if (inputType.IsEnumType() &&
+                value is StringValueNode)
+            {
+                return false;
+            }
+
             return internalType.IsInstanceOfType(value);
         }
 

diff --git a/src/HotChocolate/Core/test/Validation.Tests/ValuesOfCorrectTypeRuleTests.cs b/src/HotChocolate/Core/test/Validation.Tests/ValuesOfCorrectTypeRuleTests.cs
@@ -619,8 +619,7 @@ public void BadFloatIntoEnum()
             ");
         }
 
-        // is this something that we find ok or should we change it back?
-        [Fact(Skip = "We do allow this at the moment.")]
+        [Fact]
         public void BadStringIntoEnum()
         {
             ExpectErrors(@"