Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilterTypes produce schema errors when filters properties are nullable. #1034

Closed
michaelstaib opened this issue Aug 26, 2019 · 1 comment
Closed
Assignees
Milestone

Comments

@michaelstaib
Copy link
Member

Describe the bug
FilterTypes produce schema errors when filters properties are nullable.

To Reproduce

public class FooNullable
{
    public short? BarShort { get; set; }
}

[Fact]
public void Model_With_Nullable_Properties()
{
    // arrange
    // act
    var schema = CreateSchema(
        new FilterInputType<FooNullable>(
            d => d.Filter(f => f.BarShort)));

    // assert
    schema.ToString().MatchSnapshot();
}

Expected behavior
The schema correctly is created without any schema error.

Desktop (please complete the following information):

  • OS: macOS
  • Version: HotChocolate Version 10.0.0
@michaelstaib
Copy link
Member Author

This one is now fixed with #1170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant