Allow filtering on nullable value type properties #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, the Bild failed cause of the coverlet issue. I will require it in a minute |
michaelstaib
approved these changes
Oct 10, 2019
michaelstaib
added a commit
that referenced
this pull request
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update FilterFieldDescriptorBase.RewriteTypeToNullableType to return the type if it is already a
Nullable<>, and insert type conversion expressions where necessary in FilterExpressionBuilder.Fixes #1034.
I saw that the first half of this fix was made by @PascalSenn in #1105, but the FilterExpressionBuilder change is required as well, and additionally, that pr is targeted at master, while this issue is under the 10.2.0 milestone.