Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoJson Point has inconsistent input and output types #2826

Closed
bram209 opened this issue Jan 6, 2021 · 3 comments · Fixed by #2829
Closed

GeoJson Point has inconsistent input and output types #2826

bram209 opened this issue Jan 6, 2021 · 3 comments · Fixed by #2829
Assignees

Comments

@bram209
Copy link

bram209 commented Jan 6, 2021

Describe the bug
The input type of a GeoJsonPoint is inconsistent with it's output type:

GeoJson Point spec

3.1.2.  Point

   For type "Point", the "coordinates" member is a single position.

Spatial/src/Types/GeoJsonPointType.cs#L17

            descriptor
                .Field(x => x.Coordinates)
                .Description(GeoJson_Field_Coordinates_Description_Point);

NetTopologySuite/Geometries/Point.cs#L77

        public override Coordinate[] Coordinates => IsEmpty ? new Coordinate[] { } : new Coordinate[] { this.Coordinate };
@bram209 bram209 changed the title Inconsistent spatial input and output types GeoJson Point has dnconsistent spatial input and output types Jan 6, 2021
@bram209 bram209 changed the title GeoJson Point has dnconsistent spatial input and output types GeoJson Point has inconsistent input and output types Jan 6, 2021
@PascalSenn PascalSenn self-assigned this Jan 6, 2021
@steveoh
Copy link
Contributor

steveoh commented Jan 6, 2021

Input types are not meant to be geojson as json isn't really a graphql input but I am curious to see what Pascals opinion is

@steveoh
Copy link
Contributor

steveoh commented Jan 6, 2021

Or is the issue the plurality of coordinates? You might explain yourself and why you posted those links so we don't have to infer and assume

@ghost
Copy link

ghost commented Jan 7, 2021

This issue's conversation has been locked. Please file a new issue if you would like to continue the discussion.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants