Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strawberry Shake: Configurable access for generated clients #6374

Closed
kmcclellan opened this issue Jul 21, 2023 · 1 comment · Fixed by #6416
Closed

Strawberry Shake: Configurable access for generated clients #6374

kmcclellan opened this issue Jul 21, 2023 · 1 comment · Fixed by #6416

Comments

@kmcclellan
Copy link

Product

Strawberry Shake

Is your feature request related to a problem?

The strawberry shake client types are generated with the public access modifier. This is inconvenient for apps that are broken into multiple assemblies that want to hide their implementation details from each other.

The solution you'd like

It'd be nice if we could configure the access modifier in graphqlrc.json. I'd even argue that internal should be the default.

nih0n pushed a commit to nih0n/graphql-platform that referenced this issue Aug 6, 2023
nih0n pushed a commit to nih0n/graphql-platform that referenced this issue Aug 6, 2023
nih0n pushed a commit to nih0n/graphql-platform that referenced this issue Aug 6, 2023
nih0n pushed a commit to nih0n/graphql-platform that referenced this issue Aug 6, 2023
nih0n pushed a commit to nih0n/graphql-platform that referenced this issue Aug 6, 2023
nih0n pushed a commit to nih0n/graphql-platform that referenced this issue Aug 6, 2023
nih0n pushed a commit to nih0n/graphql-platform that referenced this issue Aug 9, 2023
@EnsignPayton
Copy link

EnsignPayton commented Aug 23, 2023

Internal as a default is a breaking change, my solution has 52 errors after upgrading to StrawberryShake.Server 13.5.0 and I'm not exactly sure how to fix it. I tried adding access modifier to my graphqlrc, but apparently I don't have the right syntax

Edit:

"accessModifier": "public" works, it just didn't take effect until after I restarted Rider and ran git clean -xdf. Probably needed to clear bin and obj.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants