Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotChocolate.Caching 13.9.0 returns empty response #7054

Closed
kiangkuang opened this issue Apr 13, 2024 · 9 comments · Fixed by #7441
Closed

HotChocolate.Caching 13.9.0 returns empty response #7054

kiangkuang opened this issue Apr 13, 2024 · 9 comments · Fixed by #7441

Comments

@kiangkuang
Copy link
Contributor

Product

Hot Chocolate

Version

13.9.0

Link to minimal reproduction

https://github.com/kiangkuang/HotChocolateDemo/tree/13.9

Steps to reproduce

  1. Clone project
  2. Run project and query with
    query {
        book {
            title
        }
    }
    

What is expected?

Response with cache control headers and query result, like in version 13.8.1
image

What is actually happening?

Response with cache control headers but response is empty
image

Relevant log output

No response

Additional context

No response

@tobias-tengler
Copy link
Collaborator

I'm able to reproduce this. Looking into it.

@tobias-tengler
Copy link
Collaborator

This seems to have been broken since #6844. The snapshots even shows us that it's broken 😞
https://github.com/ChilliCream/graphql-platform/pull/6844/files#diff-2803ba1ef05352c4221908b033e53e6563c564873702b5ced27ddd6b495f0f5d

@miko866
Copy link

miko866 commented May 14, 2024

Same probleme here.
I use:
.AddCacheControl()
.ModifyCacheControlOptions(o => o.DefaultMaxAge = 60_000)
.UseQueryCachePipeline()

HotChocolate.AspNetCore - 13.9.3
HotChocolate.Caching - 13.9.3

@michaelstaib
Copy link
Member

@tobias-tengler is this fixed? What is the issue here?

@tobias-tengler
Copy link
Collaborator

This right here still needs to be addressed: #7057 (comment)
It probably needs some more considerations. Would be great if you could take a look :)

@miko866
Copy link

miko866 commented Jul 16, 2024

The problem still persists in the version 13.9.7

@keevee1988
Copy link

I am using HotChocolate.AspNetCore - 13.9.12, HotChocolate.Caching - 13.9.12 still facing same issue

Program.cs
.AddGraphQLServer()
.AllowIntrospection(false)
.AddAuthorization()
.AddFiltering()
.AddProjections()
.AddQueryType()
.AddTypeExtension()
.AddSorting()
.AddCacheControl()
.UseQueryCachePipeline()
.InitializeOnStartup();

@kiangkuang
Copy link
Contributor Author

@keevee1988 13.9.12 does not include the merged fix yet, you can try waiting for the next release

@keevee1988
Copy link

@keevee1988 13.9.12 does not include the merged fix yet, you can try waiting for the next release

Thank you for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants