Fix QueryResult creation in QueryCacheMiddleware #7057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-tengler
force-pushed
the
fix-empty-caching-result
branch
from
9729439 to
32bbfc8
Compare
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
tobias-tengler
commented
Apr 14, 2024
Comment on lines
+61
to
+62
| // TODO: This is probably problematic | ||
| cleanupTasks: [], |
There was a problem hiding this comment.
This still needs to be addressed
michaelstaib
force-pushed
the
main
branch
2 times, most recently
from
8a97a79 to
e2d2300
Compare
michaelstaib
requested review from
michaelstaib
and removed request for
michaelstaib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6844 broke the existing caching functionality by changing how a
QueryResultis being constructed.This aligns the construction to the new approach.
Fixes #7054