-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refined unignore for V10 #1468
Refined unignore for V10 #1468
Changes from all commits
e8d7aca
53bc518
78b6a18
994d6c3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -174,6 +174,4 @@ IObjectTypeDescriptor<T> Directive( | |
NameString name, | ||
params ArgumentNode[] arguments); | ||
} | ||
|
||
|
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,7 +94,10 @@ public IInterfaceTypeDescriptor Description(string value) | |
public IInterfaceFieldDescriptor Field(NameString name) | ||
{ | ||
InterfaceFieldDescriptor fieldDescriptor = | ||
Fields.FirstOrDefault(t => t.Definition.Name.Equals(name)); | ||
Fields.FirstOrDefault(t => | ||
t.Definition.Name.Equals(name) | ||
&& !t.Definition.Ignore); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fields is also used in the generic version because of |
||
|
||
if (fieldDescriptor is { }) | ||
{ | ||
return fieldDescriptor; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -236,7 +236,9 @@ public IObjectTypeDescriptor IsOfType(IsOfType isOfType) | |
public IObjectFieldDescriptor Field(NameString name) | ||
{ | ||
ObjectFieldDescriptor fieldDescriptor = | ||
Fields.FirstOrDefault(t => t.Definition.Name.Equals(name)); | ||
Fields.FirstOrDefault(t => | ||
t.Definition.Name.Equals(name) | ||
&& !t.Definition.Ignore); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fields is also used in the generic version because of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But in that case it does not matter since the collision is only on names. I however think we should change the data structure to better controls ignored members. |
||
if (fieldDescriptor is { }) | ||
{ | ||
return fieldDescriptor; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is also using ``Arguments`