Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat use selection improvements #1555

Merged
merged 18 commits into from
Mar 16, 2020

Conversation

PascalSenn
Copy link
Member

Improvements on UseSelection

@PascalSenn PascalSenn changed the title Feat use selection improvements 🚧WIP🚧: Feat use selection improvements Mar 14, 2020
@PascalSenn PascalSenn changed the title 🚧WIP🚧: Feat use selection improvements Feat use selection improvements Mar 14, 2020
@TheJayMann
Copy link

I noticed that this pull request implements a SingleOrDefault middleware. Could a FirstOrDefault middleware be added as well, or even modify the SingleOrDefault middleware to be generic enough that it either uses SingleOrDefault or FirstOrDefault depending on how it was set up? Something like public static IObjectFieldDescriptor UseSingleOrDefault(this IObjectFieldDescriptor descriptor, bool allowMultipleResults).

@michaelstaib
Copy link
Member

We are still missing first or default. I really think that first or default is what we want not single or default. I will rework the pr to include first or default.

@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 8 Code Smells

82.0% 82.0% Coverage
1.2% 1.2% Duplication

@michaelstaib
Copy link
Member

@TheJayMann we opted for a second attribute.

We will add more attributes in 11 but for 10 I thing with FirstOrDefault and SingleOrDefault we should be ok

@michaelstaib michaelstaib merged commit e0d0574 into version_10_0_0_master Mar 16, 2020
@michaelstaib michaelstaib deleted the FEAT_use-selection-improvements branch March 16, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants