-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat use selection improvements #1555
Feat use selection improvements #1555
Conversation
I noticed that this pull request implements a SingleOrDefault middleware. Could a FirstOrDefault middleware be added as well, or even modify the SingleOrDefault middleware to be generic enough that it either uses SingleOrDefault or FirstOrDefault depending on how it was set up? Something like |
We are still missing first or default. I really think that first or default is what we want not single or default. I will rework the pr to include first or default. |
SonarCloud Quality Gate failed. 0 Bugs |
src/Core/Types.Selection/Extensions/SingleOrDefaultObjectFieldDescriptorExtensions.cs
Outdated
Show resolved
Hide resolved
src/Core/Types.Selection/Extensions/SingleOrDefaultObjectFieldDescriptorExtensions.cs
Outdated
Show resolved
Hide resolved
@TheJayMann we opted for a second attribute. We will add more attributes in 11 but for 10 I thing with FirstOrDefault and SingleOrDefault we should be ok |
Improvements on UseSelection