Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nested variables in stiching #1746

Merged
merged 6 commits into from
Apr 22, 2020
Merged

Enable nested variables in stiching #1746

merged 6 commits into from
Apr 22, 2020

Conversation

PascalSenn
Copy link
Member

@PascalSenn PascalSenn commented Apr 21, 2020 •
edited
Loading

  • Enables variables in input object : query {field(arg:{deep:{deep:{val:$variable}}}})}
  • Enables variables in lists object : query {field(arg:{arr:[{deep:{val:$variable}}}]})}

@PascalSenn PascalSenn changed the base branch from master to version_10_0_0_master April 21, 2020 21:42
@michaelstaib michaelstaib self-requested a review April 21, 2020 21:53
@michaelstaib michaelstaib added this to the HC-10.4.3 milestone Apr 21, 2020
@michaelstaib
Copy link
Member

There are two snapshots tests that fail.

@michaelstaib
Copy link
Member

also this has to be fixed on 11

@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

81.9% 81.9% Coverage
1.6% 1.6% Duplication

@PascalSenn PascalSenn linked an issue Apr 21, 2020 that may be closed by this pull request
stitching misses used variables in complex input types #1742
Closed
@PascalSenn
Copy link
Member Author

@michaelstaib sorry forgot about WIP:
Should be ready now. V11 is comming

@michaelstaib michaelstaib merged commit 257fb51 into ChilliCream:version_10_0_0_master Apr 22, 2020
@PascalSenn PascalSenn mentioned this pull request Apr 23, 2020
Closed
@joslat joslat mentioned this pull request Apr 25, 2020
Merged
@gao-artur gao-artur mentioned this pull request Jun 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees

@PascalSenn PascalSenn

Labels
None yet
Projects
None yet
Milestone
HC-10.4.3
Development

Successfully merging this pull request may close these issues.

stitching misses used variables in complex input types
2 participants
@PascalSenn @michaelstaib