Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues with Apollo active persisted queries flow. #2864

Merged
merged 8 commits into from
Jan 12, 2021

Conversation

michaelstaib
Copy link
Member

HTTP GET requests that do not provide a id or query parameter fail by default which in turn doesn't allow for the Apollo active persisted query flow while using HTTP GET requests. With this PR we are now also looking for a query has in the extensions parameter before failing.

https://www.apollographql.com/docs/apollo-server/performance/apq/

@michaelstaib michaelstaib linked an issue Jan 11, 2021 that may be closed by this pull request
@michaelstaib michaelstaib self-assigned this Jan 11, 2021
@michaelstaib michaelstaib merged commit 2a9fba3 into main Jan 12, 2021
@michaelstaib michaelstaib deleted the mst/apollo-active-persisted-query branch January 12, 2021 23:13
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic persisted queries not working with Apollo client
1 participant