-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support [ID]! arrays in ID formatter. #3440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccallum
commented
Apr 6, 2021
src/HotChocolate/Core/src/Types/Types/Relay/GlobalIdInputValueFormatter.cs
Outdated
Show resolved
Hide resolved
benmccallum
commented
Apr 6, 2021
...ore/test/Types.Tests/Types/Relay/__snapshots__/IdAttributeTests.Id_On_Objects_InvalidId.snap
Show resolved
Hide resolved
Is this ready for review? |
benmccallum
commented
Apr 7, 2021
src/HotChocolate/Core/test/Types.Tests/HotChocolate.Types.Tests.csproj
Outdated
Show resolved
Hide resolved
benmccallum
commented
Apr 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @michaelstaib , it's ready now, sorry I thought I was done yesterday but had some more ideas to streamline this.
...hocolate/Core/test/Types.Tests/Types/Relay/__snapshots__/IdAttributeTests.Id_On_Objects.snap
Show resolved
Hide resolved
...e/test/Types.Tests/Types/Relay/__snapshots__/IdAttributeTests.Id_On_Objects_Given_Nulls.snap
Show resolved
Hide resolved
michaelstaib
approved these changes
Apr 13, 2021
michaelstaib
changed the title
Support [ID]! arrays
Support [ID]! arrays in ID formatter.
Apr 13, 2021
michaelstaib
approved these changes
Apr 13, 2021
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a subtle bug in the existing code when handling arrays with nullable items when passed a null item.
Edit: I've since realised/remembered that arrays with nullable items is a really weird thing to do; but in any case; since it's allowed we should support it.
Details:
In the case of the
is IEnumerable<string>
, since an enumerable ofstring
orstring?
both pass this check, if a null was passed in the array, it'd be passed to theIIdSerializer
Deserialize method which would throw. This can be fixed by typing that toIEnumerable<string?>
and then handling nulls appropriately, just adding null to the array.In the case of the
is IEnumerable<IdValue>
, sinceIEnumerable<IdValue?>
doesn't pass the check, my polymorphic id formatter (which intercepts and sets anIEnumerable<IdValue?>
can never have it's value picked up and used, so that did need a new block of code to handle.Testing: