Code documentation for most of IDiagnosticEvents et al #3454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After digging through the code to find out how to use these interfaces in my code it seemed a waste not to also write down what I learned and submit it :) |
|
Awesome! |
michaelstaib
added
🌶 hot chocolate
📚 documentation
I'm not sure what an IExecutionTask really is, but it is worthwhile pointing out the dependency on IDiagnosticEventListener.EnableResolveFieldValue.
michaelstaib
approved these changes
Apr 9, 2021
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
I chipped in some more documentation about the request context and the missing instrumentation events. Thanks so much for your work on this! |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
IDiagnosticEvents(skipped methods where I wasn't sure exactly what they do)IDiagnosticEventsListenerDiagnosticEventsListenerNo related issue.