Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove solution from StarWars template #3524

Merged
merged 2 commits into from
Apr 17, 2021

Conversation

tobias-tengler
Copy link
Collaborator

For me there's no clear reason, why the StarWars example needs a solution file.
This is just something I wouldn't expect from dotnet new and it introduces a new subfolder nobody really needs.
This PR aligns the StarWars example with the Server Template.

@sonarcloud
Copy link

sonarcloud bot commented Apr 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@michaelstaib
Copy link
Member

Yes... let's remove it. Having just a project also aligns it with the empty template.

@michaelstaib michaelstaib merged commit c0c4aef into main Apr 17, 2021
@michaelstaib michaelstaib deleted the tte/no-solution-in-starwars-example branch April 17, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants