Fixed memory leaks in subscriptions #3608
Conversation
…ubscriptions)
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Great .... thanks for putting this together ... we will do a review tonight. |
|
Fixed tests |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
src/HotChocolate/AspNetCore/src/AspNetCore/Subscriptions/Subscription.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/AspNetCore/src/AspNetCore/Subscriptions/Subscription.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Core/src/Execution/Processing/SubscriptionExecutor.Subscription.cs
Outdated
Show resolved
Hide resolved
|
TODO @michaelstaib
|
|
@akolpachev I have a small todo list for this which I will work through tomorrow. This I great work. We will merge it once I have ticked of my items on this probably tomorrow afternoon. It will be included into the next preview. |
|
Nice. Thank you. |
src/HotChocolate/Core/src/Execution/Processing/SubscriptionExecutor.Subscription.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Core/src/Execution/Processing/OperationContextPoolPolicy.cs
Show resolved
Hide resolved
src/HotChocolate/Core/src/Execution/Processing/OperationContextPoolPolicy.cs
Show resolved
Hide resolved
tobias-tengler
changed the title
|
I am done with the PR. If you two (@akolpachev, @PascalSenn) would have another look through it I would be thankful. I put a lot more comments into several parts to help future contributors. Also we have no better diagnostic events and I fixed some of the naming on the transport side. |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Tests look good ... The sonar build error is due to a flaky test. So no worries there. |
|
@PascalSenn I would be read to merge if you give me thumbs up. |
src/HotChocolate/Core/src/Execution/Instrumentation/NoOpDiagnosticEvents.cs
Outdated
Show resolved
Hide resolved
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
SonarCloud Quality Gate failed. |
Outgoing channel is closed now if related subscription or websocket is closed. MessageReceiver is stopped if error happens in linked message processor. OperationContext is marked as completed in subscribe operation.
Closes #2740
Closes #3595