Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark descriptor.Interface as obsolete #3672

Merged
merged 4 commits into from
May 6, 2021
Merged

Mark descriptor.Interface as obsolete #3672

merged 4 commits into from
May 6, 2021

Conversation

tobias-tengler
Copy link
Collaborator

@tobias-tengler tobias-tengler commented May 6, 2021 •
edited
Loading

  • Marks all occurrences of descriptor.Interface as obsolete
  • Tests and StarWars now use descriptor.Implements
  • descriptor.Interface now calls descriptor.Implements, making it easier to remove

@sonarcloud
Copy link

sonarcloud bot commented May 6, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

31.2% 31.2% Coverage
0.0% 0.0% Duplication

@michaelstaib michaelstaib merged commit 80bcc20 into main May 6, 2021
@michaelstaib michaelstaib deleted the tte/make-descriptor-interface-obsolete branch May 6, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees
No one assigned
Labels
🌶️ hot chocolate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobias-tengler @michaelstaib