Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "In this article" section #3744

Merged
merged 12 commits into from
Jun 1, 2021
Merged

Fix "In this article" section #3744

merged 12 commits into from
Jun 1, 2021

Conversation

tobias-tengler
Copy link
Collaborator

@tobias-tengler tobias-tengler commented May 27, 2021 •
edited
Loading

  • Switch to gatsby-remark-autolink-headers
  • Support identical headings within same document
  • Extract logic to determine active ToC item into a useActiveHeadingLink hook

Fixes #3580

@tobias-tengler tobias-tengler changed the title WIP: Fix "In this article" section Fix "In this article" section May 27, 2021
@tobias-tengler tobias-tengler marked this pull request as ready for review May 27, 2021 14:52
@tobias-tengler tobias-tengler requested a review from rstaib May 27, 2021 14:52
@tobias-tengler tobias-tengler mentioned this pull request May 28, 2021
Merged
@tobias-tengler tobias-tengler self-assigned this May 28, 2021
rstaib
rstaib requested changes May 31, 2021
View reviewed changes
Copy link
Member

@rstaib rstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few minor things. Thank you Tobias!

website/gatsby-config.js Show resolved Hide resolved
website/gatsby-config.js Show resolved Hide resolved
website/src/components/articles/article-sections.tsx Outdated Show resolved Hide resolved
website/src/components/articles/article-sections.tsx Outdated Show resolved Hide resolved
website/src/components/articles/article-sections.tsx Outdated Show resolved Hide resolved
website/src/components/articles/article-sections.tsx Outdated Show resolved Hide resolved
website/src/components/articles/article-sections.tsx Show resolved Hide resolved
website/src/components/structure/main-content-container/main-content-container.tsx Outdated Show resolved Hide resolved
@tobias-tengler
Copy link
Collaborator Author

@rstaib all done!

rstaib
rstaib requested changes Jun 1, 2021
View reviewed changes
Copy link
Member

@rstaib rstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing and than you're good to go 😉

website/src/components/structure/main-content-container/main-content-container.tsx Show resolved Hide resolved
rstaib
rstaib approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@rstaib rstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go! Thanks again!

@rstaib rstaib merged commit 7c1c9f4 into main Jun 1, 2021
@rstaib rstaib deleted the tte/fix-toc branch June 1, 2021 15:26
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstaib rstaib rstaib approved these changes

Assignees

@tobias-tengler tobias-tengler

Labels
🌶️ website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobias-tengler @rstaib