Added support for DateOnly and TimeOnly in MongoDB

[daviddesmet]

Summary of the changes (Less than 80 chars)

• Added support for DateOnly and TimeOnly in MongoDB

Closes #4648 (The type of the member Date of the declaring type TransactionSummary is unknown)

[PascalSenn]

Looks good :)
Could you also add tests like in https://github.com/ChilliCream/hotchocolate/pull/4552/files? :)
The test setup will be slightly different, but there are already a log of tests in the mongo test repo.

[daviddesmet]

@PascalSenn Of course, I’ll work on them 😉

[daviddesmet]

@PascalSenn When working on the DateOnly tests I've noticed MongoDB C# driver still doesn't support DateOnly and TimeOnly times, there's an open request here. Not sure how long it will take them to include it in the driver so the only way I see for the tests to pass is to create a custom Mongo Serializer until they add support for it, this should be called in the constructor for the tests, like so:

public MongoDbFilterVisitorDateOnlyTests(MongoResource resource)
{
	Init(resource);

	var dateOnlySerializer = new DateOnlySerializer(true);
	if (!BsonClassMap.IsClassMapRegistered(typeof(Foo)))
	{
		BsonClassMap.RegisterClassMap<Foo>(cm =>
		{
			cm.AutoMap();
			cm.MapMember(c => c.Bar).SetSerializer(dateOnlySerializer);
		});
	}
}

This RegisterClassMap will have to be called by developers willing to support those types anyway.

I personally don't like to do this kind of workarounds in the tests. I would rather prefer to leave the tests prepared without such a workaround and when they support it, we can merge this PR. What do you think?

[PascalSenn]

@daviddesmet hmm i see, i personally do not mind the specific setup in the tests. I don't think we need to specify each property, i think it's enough to register the serializer for the type

From the issue on Jira

BsonSerializer.RegisterSerializer(new DateOnlySerializer());
--
 
internal class DateOnlySerializer : StructSerializerBase<DateOnly>
{
   ....
}

[daviddesmet]

@PascalSenn sounds good, I will make the changes and update my PR.

[daviddesmet]

@PascalSenn I've added the DateOnly tests, feel free to check them out while I work on the TimeOnly tests.
Btw, would you also want me to add tests for comparisons? Like greater than, less than, etc?

[PascalSenn]

@DavidSMET this looks very good! Will review ist ASAP!

[daviddesmet]

@PascalSenn aye! Let me know if you also want the comparisons tests. Btw, you mentioned another Smet :P

[daviddesmet]

@PascalSenn What's the format for passing a TimeSpan in the query? Afaik is ISO8601 but I'm still getting

TimeSpan cannot parse the given literal of type `StringValueNode`.

I've tried with below queries without any luck:

{ root(where: { bar: { eq: \"06:30:00\" } }){ bar } }

{ root(where: { bar: { eq: \"06:30:00.000\" } }){ bar } }

{ root(where: { bar: { eq: \"6:30:00\" } }){ bar } }

{ root(where: { bar: { eq: \"6:30:00.000\" } }){ bar } }

{ root(where: { bar: { eq: \"6:30\" } }){ bar } }

Those are for the TimeOnly tests

Edit: Nevermind! Found out that I need to specify the TimeSpan type as:

.AddType(new TimeSpanType(TimeSpanFormat.DotNet))

All tests are now passing =)

[PascalSenn]

Great addition! Just made a couple of formatting stuf, apart from that, we'll merge that as is! great job :)
Thanks for the contribution!!

[daviddesmet]

It was my pleasure!

[PascalSenn]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication