Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTF-8 without BOM for SyntaxPrinter #4925

Merged
merged 20 commits into from
Jan 21, 2024

Conversation

tobias-tengler
Copy link
Collaborator

@tobias-tengler tobias-tengler commented Apr 4, 2022

  • Writes schema to output stream using UTF-8 without BOM encoding
  • Fixes snapshots impacted by this change
  • Also removes some unused snapshot files

Closes #4912

@tobias-tengler tobias-tengler added the 👓 ready-for-review The PR is ready for review. label Apr 4, 2022
@tobias-tengler tobias-tengler self-assigned this Apr 4, 2022
@tobias-tengler tobias-tengler removed the 👓 ready-for-review The PR is ready for review. label Apr 4, 2022
@michaelstaib
Copy link
Member

@tobias-tengler do not worry about the tests, we are on it .... we should be green again by next week.

@tobias-tengler tobias-tengler force-pushed the tte/export-schema-as-utf8-without-bom branch from 6bf9e9d to badcc39 Compare April 6, 2022 20:11
@tobias-tengler tobias-tengler force-pushed the tte/export-schema-as-utf8-without-bom branch from badcc39 to 34f729d Compare April 6, 2022 20:17
@tobias-tengler
Copy link
Collaborator Author

Resolved all of the test failures that were caused by this change. So this should be good to go! :)

@tobias-tengler tobias-tengler added the 👓 ready-for-review The PR is ready for review. label Apr 6, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2022

CLA assistant check
All committers have signed the CLA.

@stale stale bot added the ⌛ stale Nothing happened with this issue in quite a while label Dec 23, 2022
@tobias-tengler
Copy link
Collaborator Author

I think this would still be valuable.

@stale stale bot removed the ⌛ stale Nothing happened with this issue in quite a while label Dec 23, 2022
@ChilliCream ChilliCream deleted a comment from stale bot Dec 5, 2023
Copy link

github-actions bot commented Dec 6, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb04265) 70.68% compared to head (14b096a) 70.56%.

❗ Current head 14b096a differs from pull request most recent head d180c32. Consider uploading reports for the commit d180c32 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4925      +/-   ##
==========================================
- Coverage   70.68%   70.56%   -0.12%     
==========================================
  Files        2499     2485      -14     
  Lines      126165   125529     -636     
==========================================
- Hits        89175    88585     -590     
+ Misses      36990    36944      -46     
Flag Coverage Δ
unittests 70.56% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…Tests/Integration/StarWarsOnReviewSubCompletionTest.Client.cs
…Tests/Integration/StarWarsIntrospectionTest.Client.cs
…Tests/Integration/MultiProfileTest.Client.cs
…Tests/Integration/MultiProfileTest.Client.cs
@michaelstaib michaelstaib merged commit 4196aba into main Jan 21, 2024
9 checks passed
@michaelstaib michaelstaib deleted the tte/export-schema-as-utf8-without-bom branch January 21, 2024 14:10
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

?sdl returns file encoded as UTF-8 with BOM
4 participants