-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use UTF-8 without BOM for SyntaxPrinter #4925
Conversation
@tobias-tengler do not worry about the tests, we are on it .... we should be green again by next week. |
6bf9e9d
to
badcc39
Compare
badcc39
to
34f729d
Compare
Resolved all of the test failures that were caused by this change. So this should be good to go! :) |
Kudos, SonarCloud Quality Gate passed! |
I think this would still be valuable. |
src/HotChocolate/Language/src/Language.SyntaxTree/Utilities/SyntaxPrinter.cs
Outdated
Show resolved
Hide resolved
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4925 +/- ##
==========================================
- Coverage 70.68% 70.56% -0.12%
==========================================
Files 2499 2485 -14
Lines 126165 125529 -636
==========================================
- Hits 89175 88585 -590
+ Misses 36990 36944 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...ion/test/CodeGeneration.CSharp.Tests/Integration/StarWarsOnReviewSubCompletionTest.Client.cs
Show resolved
Hide resolved
…Tests/Integration/StarWarsOnReviewSubCompletionTest.Client.cs
...eGeneration/test/CodeGeneration.CSharp.Tests/Integration/StarWarsIntrospectionTest.Client.cs
Show resolved
Hide resolved
…Tests/Integration/StarWarsIntrospectionTest.Client.cs
...Shake/CodeGeneration/test/CodeGeneration.CSharp.Tests/Integration/MultiProfileTest.Client.cs
Show resolved
Hide resolved
…Tests/Integration/MultiProfileTest.Client.cs
...Shake/CodeGeneration/test/CodeGeneration.CSharp.Tests/Integration/MultiProfileTest.Client.cs
Show resolved
Hide resolved
…Tests/Integration/MultiProfileTest.Client.cs
Closes #4912