Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow static node resolver to be defined in type/external resolver base class #5002

Conversation

Suzii
Copy link
Contributor

@Suzii Suzii commented Apr 25, 2022

  • Allows node resolver to be defined as a static method in the entity's base class
  • Allows node resolver to be defined as an inherited static method of the NodeResolverType

Closes #5001

@PascalSenn
Copy link
Member

Thanks for the PR :)

@Suzii
Copy link
Contributor Author

Suzii commented Apr 29, 2022

Thanks for the review @PascalSenn. Is there anything else I can help with to get this PR through? :)

@michaelstaib
Copy link
Member

We are currently fixing the tests on main... they should be green tomorrow. Once they are I will run the tests.

@michaelstaib
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@michaelstaib michaelstaib added the 👓 ready-for-review The PR is ready for review. label May 3, 2022
@michaelstaib
Copy link
Member

The tests look good so far... will do a code review tomorrow.

@michaelstaib michaelstaib self-requested a review May 3, 2022 23:45
@michaelstaib
Copy link
Member

/AzurePipelines run

@michaelstaib michaelstaib added 🎬 ready Ready to merge and removed 👓 ready-for-review The PR is ready for review. labels May 4, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@michaelstaib
Copy link
Member

Thanks again for contributing ... the PR is slated to be merged today 🚀

@Suzii
Copy link
Contributor Author

Suzii commented May 4, 2022

Awesome. Thank you! :) Just to confirm: the functionality will be out with the new major version v13 or is it possible to add it to some minor version of v12 as well? :)

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

90.9% 90.9% Coverage
0.0% 0.0% Duplication

@michaelstaib
Copy link
Member

@Suzii we will try to put it in 12.9

@michaelstaib michaelstaib merged commit f9dd6a6 into ChilliCream:main May 4, 2022
@michaelstaib
Copy link
Member

running the tests now for 12.9 ...

@michaelstaib
Copy link
Member

I have cherrypicked the commit to 12.9 the release build is running and it will be integrated into 12.9.0-preview.1 .... will take maybe 30 min.

@Suzii
Copy link
Contributor Author

Suzii commented May 4, 2022

Thank you again, @michaelstaib ! I installed the preview version and applied the changes, works like a charm! :)

@michaelstaib
Copy link
Member

@Suzii are you on slack? We will release today 12.9 and wanted to tag you on the release.

https://slack.chillicream.com

@michaelstaib
Copy link
Member

Ping me on slack

@Suzii
Copy link
Contributor Author

Suzii commented May 11, 2022

I sent you a PM :) My Slack name is Zuzana Sojcikova.

@Suzii Suzii deleted the allow_inherited_members_to_be_considered_as_resolvers branch May 11, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node resolvers do not support inherited members
3 participants