-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow static node resolver to be defined in type/external resolver base class #5002
Allow static node resolver to be defined in type/external resolver base class #5002
Conversation
src/HotChocolate/Core/src/Execution/Extensions/ExecutionSchemaExtensions.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Core/test/Types.Tests/Types/Relay/NodeFieldSupportTests.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Core/src/Types/Types/Relay/Attributes/NodeAttribute.cs
Outdated
Show resolved
Hide resolved
Thanks for the PR :) |
Thanks for the review @PascalSenn. Is there anything else I can help with to get this PR through? :) |
We are currently fixing the tests on main... they should be green tomorrow. Once they are I will run the tests. |
/AzurePipelines run |
Azure Pipelines successfully started running 3 pipeline(s). |
The tests look good so far... will do a code review tomorrow. |
/AzurePipelines run |
Azure Pipelines successfully started running 3 pipeline(s). |
Thanks again for contributing ... the PR is slated to be merged today 🚀 |
Awesome. Thank you! :) Just to confirm: the functionality will be out with the new major version v13 or is it possible to add it to some minor version of v12 as well? :) |
Kudos, SonarCloud Quality Gate passed! |
@Suzii we will try to put it in 12.9 |
running the tests now for 12.9 ... |
I have cherrypicked the commit to 12.9 the release build is running and it will be integrated into 12.9.0-preview.1 .... will take maybe 30 min. |
Thank you again, @michaelstaib ! I installed the preview version and applied the changes, works like a charm! :) |
@Suzii are you on slack? We will release today 12.9 and wanted to tag you on the release. |
Ping me on slack |
I sent you a PM :) My Slack name is Zuzana Sojcikova. |
NodeResolverType
Closes #5001