Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced Syntax Comparer #5023

Merged
merged 6 commits into from
May 3, 2022
Merged

Introduced Syntax Comparer #5023

merged 6 commits into from
May 3, 2022

Conversation

michaelstaib
Copy link
Member

No description provided.

@matt-psaltis
Copy link
Contributor

Hi Michael, Is this because equality is contextual? thanks

@michaelstaib
Copy link
Member Author

The behavior change is too big and the rippling effect we have across the code would take to much time to absorb. With the new SyntaxComparer we will get the same benefits but can opt-in. I hope I have a working V13 branch by tomorrow. Once we are green again we can move forward on stitching.

@michaelstaib michaelstaib merged commit d15dc6b into main May 3, 2022
@michaelstaib michaelstaib deleted the mst/syntax-comparer branch May 3, 2022 19:02
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 50 Code Smells

78.6% 78.6% Coverage
5.9% 5.9% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🌶️ hot chocolate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelstaib @matt-psaltis