Always use NtsGeometryServices instance for geometry creation #5048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PascalSenn
approved these changes
May 26, 2022
PascalSenn
approved these changes
Jun 9, 2022
|
@wassim-k Sorry that it took so long to review this one! Just fixed the CRS Resolver as now the default CRS is -1. I guess we anyway have an issue in this resolver we have to address at some point. But for now, the behaviour stays the same at least ;) Great work, thanks for the contribution. LGTM |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetTopologySuite Getting Started recommends modifying
NtsGeometryServices.Instancewith the your own desired defaults.Unfortunately, HotChocolate currently ignores those defaults by calling constructors of NTS Geometry classes directly instead of using
GeometryFactoryThis PR is a demonstration of the required change in order to respect the defaults set by
NtsGeometryServices.Instanceand I guess a way to start the discussion.Thoughts?