Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify observer to complete async stream on network error. #5060

Merged
merged 10 commits into from
Nov 7, 2022
Merged

Notify observer to complete async stream on network error. #5060

merged 10 commits into from
Nov 7, 2022

Conversation

CoreDX9
Copy link
Contributor

@CoreDX9 CoreDX9 commented May 12, 2022

  1. Fixed unit test for pull request notify observer to complete async stream #5008. The OnCompleted callback may be triggered accidentally by Dispose method.
  2. Notify observer to complete async stream on network error.

Closes #5006

…ay be triggered accidentally by Dispose method. 2. Notify observer to complete async stream on network error.
@michaelstaib
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@michaelstaib
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2022

CLA assistant check
All committers have signed the CLA.

@michaelstaib
Copy link
Member

@CoreDX9 could you sign the CLA so we can merge this now? Finally got back to this PR :)

@michaelstaib michaelstaib merged commit 10263bb into ChilliCream:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make StrawberryShake's subscription can finish automatically.
3 participants