Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed deserialization of negative TimeSpans. (#5075) #5076

Merged
merged 4 commits into from Jun 9, 2022
Merged

Fixed deserialization of negative TimeSpans. (#5075) #5076

merged 4 commits into from Jun 9, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 18, 2022

Removed use of NegativeBit and added explicit isNegative flag.

  • Fixed negative values in HotChocolate/.../Iso8601Duration
  • Fixed negative values in StrawberryShake/.../Iso8601Duration
  • Added unit tests for negative values in HotChocolate and StrawberryShake.

Closes #5075

@PascalSenn PascalSenn self-assigned this May 18, 2022
PascalSenn
PascalSenn approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@PascalSenn PascalSenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and sorry that it took so long to review.

Very good work, just added a few test to see if nanoseconds are still working properly

@PascalSenn PascalSenn added the 🎬 ready Ready to merge label Jun 9, 2022
@michaelstaib michaelstaib merged commit 5c712c4 into ChilliCream:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@PascalSenn PascalSenn

Labels
🌶️ hot chocolate 🎬 ready Ready to merge 🌶️ strawberry shake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iso8601Duration produces incorrect results for negative values
2 participants
@PascalSenn @michaelstaib