Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description on totalCount field in connection type #5212

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Description on totalCount field in connection type #5212

merged 2 commits into from
Jul 7, 2022

Conversation

damienpontifex
Copy link
Contributor

Adding in description too totalCount field that optionally appears on connection type.

  • Used description from the GitHub.graphql file from within the execution benchmarks folder as content for description
  • Only field (that I saw) on built in connection type that doesn't have a field comment, so rounding it out so all do
  • (selfishly) makes our linter happy such that "all fields have descriptions"

@tobias-tengler
Copy link
Collaborator

/azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@michaelstaib michaelstaib merged commit 436119f into ChilliCream:main Jul 7, 2022
@michaelstaib
Copy link
Member

thanks for your help

@damienpontifex damienpontifex deleted the connection-totalcount-description branch July 7, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees
No one assigned
Labels
🌶️ hot chocolate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damienpontifex @tobias-tengler @michaelstaib