Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant IHasScope removed #5338

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Redundant IHasScope removed #5338

merged 3 commits into from
Aug 25, 2022

Conversation

nirzaf
Copy link
Contributor

@nirzaf nirzaf commented Aug 24, 2022

  • Base interface 'IHasScope' is redundant because HotChocolate.Data.Filters.FilterFieldDefinition implements 'IFilterFieldDefinition' which contains IHasScope interface in it already

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ nirzaf
✅ michaelstaib
❌ mmfazrin-phcc-gov
You have signed the CLA already but the status is still pending? Let us recheck it.

@michaelstaib
Copy link
Member

Thank you for contributing.

@MFM_Fazrin also needs to sign the CLA for this to procede.

@michaelstaib
Copy link
Member

@PascalSenn can you verify the change?

@nirzaf
Copy link
Contributor Author

nirzaf commented Aug 25, 2022

Thank you for contributing.

@MFM_Fazrin also needs to sign the CLA for this to procede.

I already Signed, I don't how the other name "MFM_Fazrin" appear there, I have only one account with the username "nirzaf", and I could not Sign on behalf of "MFM_Fazrin" it is a request to add an email linked to this account, but I don't use any other account

@michaelstaib
Copy link
Member

Its the email that you have in your local git config: mmfazrin@phcc.gov.qa

@michaelstaib
Copy link
Member

I will squash the commit and then this email will be gone.

@michaelstaib michaelstaib merged commit b79e112 into ChilliCream:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants