-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redundant IHasScope removed #5338
Conversation
nirzaf
commented
Aug 24, 2022
•
edited by michaelstaib
Loading
edited by michaelstaib
- Base interface 'IHasScope' is redundant because HotChocolate.Data.Filters.FilterFieldDefinition implements 'IFilterFieldDefinition' which contains IHasScope interface in it already
…ters.FilterFieldDefinition implements 'IFilterFieldDefinition'
|
Thank you for contributing. @MFM_Fazrin also needs to sign the CLA for this to procede. |
@PascalSenn can you verify the change? |
I already Signed, I don't how the other name "MFM_Fazrin" appear there, I have only one account with the username "nirzaf", and I could not Sign on behalf of "MFM_Fazrin" it is a request to add an email linked to this account, but I don't use any other account |
Its the email that you have in your local git config: mmfazrin@phcc.gov.qa |
I will squash the commit and then this email will be gone. |