Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed node resolver with entities #5429

Merged
merged 4 commits into from
Sep 25, 2022

Conversation

PascalSenn
Copy link
Member

No description provided.

@michaelstaib michaelstaib merged commit cb9265f into main Sep 25, 2022
@michaelstaib michaelstaib deleted the pse/fixed-node-resolver-with-use-projections branch September 25, 2022 07:53
/// <summary>
/// The key to get check if a field is the nodes field.
/// </summary>
public const string IsNodesField = "HotChocolate.Relay.Node.IsNodeField";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just came across this, while fixing a merge conflict in this file: Is it intentional that the value of both these context keys is the same or should this one be the plural variant? (Haven't reviewed the actual PR)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! thanks tobias!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants