Fix event stream formatter so that support graphql-sse protocol #5473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelstaib
requested changes
Oct 8, 2022
|
The protocol spec can be found here: |
michaelstaib
reviewed
Oct 8, 2022
src/HotChocolate/Core/src/Execution/Serialization/EventStreamResultFormatter.cs
Show resolved
Hide resolved
michaelstaib
reviewed
Oct 8, 2022
src/HotChocolate/Core/src/Execution/Serialization/EventStreamResultFormatter.cs
Show resolved
Hide resolved
|
OK, read into the link you posted... so I interpreted it wrongly. I will revert the changes you did to static fields so that we do not carry a static array around, but leave your fix in place. |
|
Ah damnit :) I see why you did what you did :D |
michaelstaib
approved these changes
Oct 8, 2022
|
Thank you for your help! |
|
I have integrated your fix into preview 68 ... should be available in the next 60 minutes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
EventStreamResultFormatterto format an event stream for decoding.